fix: replace ofetch native fetch #147
Open
+171
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the ofetch dependency from multiple files and replaced it with a customFetch utility for better error handling and flexibility. - Updated API calls in login, pull languages, and user actions to use the new fetch method. - Introduced a new ResponseError interface for improved error management. - Added a getStoryblokUrl utility function to centralize URL construction based on region. - Enhanced error handling in API error management to accommodate the new FetchError class.
alvarosabu
added
p3-significant
edodusi
requested changes
Jan 10, 2025
| try { | ||
| const headers = { | ||
| 'Content-Type': 'application/json', | ||
| ...options.headers, |
There was a problem hiding this comment.
since it's needed in every call, why don't you put the Authorization: $token here too? It's overridable, but it spares you from manually adding it to every single customFetch call
| fetchOptions.body = options.body | ||
| } | ||
| catch { | ||
| fetchOptions.body = JSON.stringify(options.body) |
There was a problem hiding this comment.
why you try to stringify a string here?
| data = await response.json() | ||
| } | ||
| catch { | ||
| // Ignore JSON parse errors |
There was a problem hiding this comment.
are you sure we can ignore all .json() errors here?
| }) | ||
| } | ||
|
|
||
| // Handle empty responses |
| if (contentType?.includes('application/json')) { | ||
| return await response.json() | ||
| } | ||
| return await response.text() as T |
There was a problem hiding this comment.
I don't get why if the response is json then you don't type with the generics but otherwise you return as plain text but typed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ofetchdependency from multiple files and replaced it with acustomFetchutility for better error handling and flexibility.How to test this PR
Unit tests remained the same. They are all passing
Other information