feat: replace netrc with json #146
Open
+217
−487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarosabu
added
feature
edodusi
reviewed
Jan 10, 2025
There was a problem hiding this comment.
adding an empty file here?
edodusi
requested changes
Jan 10, 2025
| } | ||
| } | ||
|
|
||
| export async function isAuthorized() { |
There was a problem hiding this comment.
this and removeAllNetrcEntries are imported and used in src/commands/logout/index.ts
edodusi
requested changes
Jan 10, 2025
|
|
||
| await initializeSession() | ||
|
|
||
| console.log(state) |
| const machines = await getNetrcCredentials() | ||
| const creds = getCredentialsForMachine(machines, machineName) | ||
| // If no environment variables, fall back to .storyblok/credentials.json | ||
| const machines = await getCredentials() |
There was a problem hiding this comment.
in a clean environment, launching a login will fail because getCredentials() if it doesn't find the credentials.json throws a filesystem error (handleFileSystemError) that should be catch and handled here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the previous approach to save login credentials on
~/.netrcfile to a more comfortable~/.storyblok/credentials.jsonsimplifying the code required and avoiding compatibility issues with other python librariesWarning
This PR doesn't include multi-region sessions. This will be done in a separate PR.
Closes #137
How to test this PR
Login credentials now should be saved at
~/.storyblok/credentials.jsonwith no disruption on the login/logout functionality