Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test when file contains a large amount of comments #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfmengels
Copy link
Collaborator

This creates a stack overflow. I am not sure how to fix it, but I have created a regression test, should anyone want to look into this 🙏

@lue-bird
Copy link
Contributor

lue-bird commented Aug 2, 2024

for reference, I tried replacing our whitespace/comments/empty primitive with a loop and it got ~10ms slower.
What I think we could do though is only start looping once we encounter a single-line comment (might be a bit rough though)

@jfmengels
Copy link
Collaborator Author

I think that would make sense, although I'm not sure what you mean by rough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants