Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalized wallet logs #1826

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

normalized wallet logs #1826

wants to merge 1 commit into from

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Jan 18, 2025

Description

To make use of data relations, we want to normalize the wallet logs. They currently don't link to invoices via foreign key but store all the data in the json context column.

However, afaict, we can't get rid of context entirely since either a) the data we want to show is unrelated to an invoice or b) the invoice was not created yet.

TODO:

  • resolve context fields required by frontend
  • refactor context in frontend?

Regression tests:

  • test status set when needed
  • test log messages still show same information in frontend

Screenshots

Additional Context

tbd

Checklist

Are your changes backwards compatible? Please answer below:

tbd

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

tbd

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

tbd

Did you introduce any new environment variables? If so, call them out explicitly here:

tbd

@ekzyis ekzyis added the wallets label Jan 18, 2025
@ekzyis ekzyis marked this pull request as draft January 18, 2025 20:47
@ekzyis ekzyis force-pushed the normalized-wallet-logs branch from 6179519 to 891cdf0 Compare January 18, 2025 20:57
@ekzyis ekzyis force-pushed the normalized-wallet-logs branch from 891cdf0 to fa46bd3 Compare January 18, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant