Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ to version control #1799

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Add FAQ to version control #1799

merged 3 commits into from
Jan 8, 2025

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Jan 5, 2025

Description

I think it's a good idea to add our special items to version control so we have a history of changes and a familiar process to discuss, review and apply changes to them. It's (unfortunately) also easier to edit these markdown documents in a proper text editor instead of the SN editor.

I've added a script that can "deploy" the markdown content via an API key from an account included in SN_USER_IDS.

For now, I only did this to the FAQ in case @huumn does not like this idea.

I tested this locally by adding my test user to SN_USER_IDS and using an API key from that test account.

@ekzyis ekzyis added documentation improvements or additions to documentation feature new product features that weren't there before labels Jan 5, 2025
@ekzyis ekzyis mentioned this pull request Jan 5, 2025
Copy link
Member

@huumn huumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in support of this - mostly for version tracking.

My main complaint is that markdown is a ambiguous toplevel directory for us to have.

I kind of likedocfood, but that's confusing in a "wtf" way.

Given this is run as a script remotely, it might make sense to put the script in scripts?

I don't know about all the other stuff, but it shouldn't be named markdown.

@ekzyis
Copy link
Member Author

ekzyis commented Jan 8, 2025

My main complaint is that markdown is a ambiguous toplevel directory for us to have.

I agree, I moved it into docs/user now

Given this is run as a script remotely, it might make sense to put the script in scripts?

👍

@huumn huumn merged commit 5261c83 into master Jan 8, 2025
6 checks passed
@huumn huumn deleted the faq branch January 8, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation feature new product features that weren't there before
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants