-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notification filters #1750
base: master
Are you sure you want to change the base?
Conversation
… as BIGINT; cleanup: better names, removed redundant code
…terIcon hints at clickability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks simple and clean. I'll QA and do UI review tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
I won't merge until after Jan. 3, and I might end up tweaking the UI and save the notification filters to localstoage for reuse, but consider it done - I'll pay up in the next few days.
I knew I was forgetting something, filter persistence! I could go and do it right away^^ |
825a566
to
0c1b64b
Compare
188aa17
to
dfa3e07
Compare
dfa3e07
to
7a8ed9b
Compare
81fc06f
to
05e7057
Compare
Description
Adds filtering by type for Notifications completing #1035
Types are represented by categories that are defined and ordered in
lib/constants.js
Like Satistics, it relies on
router.query
to apply and retrieve filters (a user can bookmark the URL).Unlike it, the modal enables multi-select before applying filters and it uses
router.replace
instead ofrouter.push
to maintain interoperability with the existing notifications pageWhen filters are applied,
localStorage
is updated with values set by the user and/orrouter.query.inc
. If filters haven't been reset, on next visits users can re-apply the last filters they choseScreenshots
Notifications page
Default modal, no filters
Modal with filters
Mobile modal
Notifications page with filters on
Additional Context
SubStatus.name as id
and casting NULLearnedSats
values toBIGINT
was necessary to make queries work on their own, could this be a problem? Notifications works as usual :PAlso I couldn't find a query for
JobChanged
so I left it as-isFilters hue for light mode maybe needs to be changed?
--theme-brandColor
Checklist
Are your changes backwards compatible? Please answer below: Yes!
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7, I couldn't reproduce some notification types! Other than that, filtering consistently works and when no filters are applied, notifications follow the same behavior as before.
For frontend changes: Tested on mobile, light and dark mode? Please answer below: Tested on mobile, PWA and also in light (additional context) and dark mode.
Did you introduce any new environment variables? If so, call them out explicitly here: No
Progress