Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolt12 support #1727
base: master
Are you sure you want to change the base?
Bolt12 support #1727
Changes from 11 commits
e803efe
332d1e1
f927fc5
494061c
8fbf5c2
f68b69d
7ff3e1b
95246bd
d326322
bae01b3
20c3e58
90f2c9c
b6cc65f
6c863d8
0e56bc8
cc993ff
efcd9a2
2411e99
28c24d5
f735d68
86a36ae
aae6de9
4191919
fa9ede4
63013c0
406d3aa
501d272
e93dc91
a1b534e
702f24e
b1b37d7
7e94360
c943284
0418486
d0e9ad8
6471ad6
9c40ddb
7ab3099
7eb5234
143d7bc
edea0e5
287e114
5cd447b
bb10b6e
5a41b01
b3365bd
10a1041
c59621d
2454a1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhh, I think ideally this would store the bolt12 offer as
bolt12
in the context instead of the bolt12 invoice asbolt11
.But I am not sure how easy it is to get the offer back from the invoice? But I think we can at least save it as
bolt12
here.I really have to do #1598 soon 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think the offer is available as part of the invoice tlv.
Can we do all the cosmetic changes from bolt11->bolt12 on a separated pr? This one is already big, propagating all the naming would add even more changes. Unless you mean something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant the user-facing stuff (so not just cosmetic imo), not renaming variables but yeah, we can do it in a separate PR. Just wanted to flag this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to take a closer look at this custom parser.