Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused wallet context args #1724

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Dec 14, 2024

Description

We were passing models and me into the wallet test functions. I think they were used in the past for logging but we no longer need them.

I also removed logger from the NWC functions since they don't use it.

Additional Context

Maybe I am overdoing it with small PRs but it's nice to get small changes out of the way so I can focus on the relevant stuff in #1558.

Checklist

Are your changes backwards compatible? Please answer below:

yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

5. I looked at all testSendPayment and testCreateInvoice function signatures and saw none of them use these arguments.

Regarding removal of logger: removing an unused argument doesn't break any function calls in JS since you can always call a function with as many arguments as you want, any arguments that aren't defined as parameters are simply not used.

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

n/a

Did you introduce any new environment variables? If so, call them out explicitly here:

no

@ekzyis ekzyis force-pushed the remove-unused-wallet-context-args branch from 8e1fad5 to 39be41a Compare December 14, 2024 10:08
@huumn huumn merged commit 77d22cf into master Dec 14, 2024
6 checks passed
@huumn huumn deleted the remove-unused-wallet-context-args branch December 14, 2024 14:55
@huumn
Copy link
Member

huumn commented Dec 14, 2024

Maybe I am overdoing it with small PRs but it's nice to get small changes out of the way so I can focus on the relevant stuff in #1558.

You aren't. It's easier to review one "subject" at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants