Remove unused wallet context args #1724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were passing
models
andme
into the wallet test functions. I think they were used in the past for logging but we no longer need them.I also removed
logger
from the NWC functions since they don't use it.Additional Context
Maybe I am overdoing it with small PRs but it's nice to get small changes out of the way so I can focus on the relevant stuff in #1558.
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
5
. I looked at alltestSendPayment
andtestCreateInvoice
function signatures and saw none of them use these arguments.Regarding removal of
logger
: removing an unused argument doesn't break any function calls in JS since you can always call a function with as many arguments as you want, any arguments that aren't defined as parameters are simply not used.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no