Allow API key access by default #1205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
force-pushed
the
api-key-default-access
branch
from
fa727fa to
6459295
Compare
|
Closing because we currently have different priorities and not the resources to deal with any potential downfall of this. For the same reasons, we're not going to allow any more API keys for the moment. We discussed that having additional filters like #690 would give us more confidence in allowing general API access. |
|
Yes I agree! |
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates every user to allow them API key access by default. The info was also updated to mention that this access can be disabled at any time.
Motivation for this is to allow anyone to build on SN without having to ask for permission in ~meta. API key access was disabled by default in #915 to limit our exposure to this new auth method. With #980 and #989 in place and after having gauged initial interest, I think it's safe to remove this requirement now.
Additionally, any item created with API keys will now be marked as
bot.Screenshots
Checklist
Are your changes backwards compatible? Please answer below:
Yes
Did you QA this? Could we deploy this straight to production? Please answer below:
Yes
For frontend changes: Tested on mobile? Please answer below:
Did you introduce any new environment variables? If so, call them out explicitly here: