Use refs for modals

[ekzyis]

Description

This fixes concurrent showModal calls with stale values which lead to modals getting replaced instead of stacked.

fixes #1194 (comment)

Additional Context

Checklist

Are your changes backwards compatible? Please answer below:

Yes

Did you QA this? Could we deploy this straight to production? Please answer below:

Searched for showModal calls and thus tested modals for QR codes, custom zaps, zoomable images, avatar upload, delete, anon info, "you will lose your work"-modal. There are more but looks good to me

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

[huumn]

Curious. How does this fix the issue described in the comment? That issue was unrelated to modals afaict

[ekzyis]

Curious. How does this fix the issue described in the comment? That issue was unrelated to modals afaict

It's related to modals because the payments weren't lost but their errors opened up a modal but you never saw all of them because only the modal for the most recent error was shown. The previous modals were simply replaced without running the onClose of the previous ones. So it only looked like they were lost, but they were still pending.¹

Footnotes

1. But they should get marked as failed with "payment was interrupted" as the reason ↩