don't support direct payments to bolt12

stackernews · Dec 17, 2024 · 332d1e1 · 332d1e1
1 parent e803efe
commit 332d1e1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/api/paidAction/index.js b/api/paidAction/index.js
@@ -264,15 +264,16 @@ async function performDirectAction (actionType, args, incomingContext) {
     invoiceObject = await createUserInvoice(userId, {
       msats: cost,
       description,
-      expiry: INVOICE_EXPIRE_SECS
+      expiry: INVOICE_EXPIRE_SECS,
+      supportBolt12: false // direct payment is not supported to bolt12 for compatibility reasons
     }, { models, lnd })
   } catch (e) {
     console.error('failed to create outside invoice', e)
     throw new NonInvoiceablePeerError()
   }
 
   const { invoice, wallet } = invoiceObject
-  const hash = await parseBolt11({ request: invoice }).id // direct payments are always to bolt11 invoices
+  const hash = await parseBolt11({ request: invoice }).id
 
   const payment = await models.directPayment.create({
     data: {

diff --git a/wallets/server.js b/wallets/server.js
@@ -47,7 +47,7 @@ async function checkInvoice (invoice, { msats }, { lnd, logger }) {
   }
 }
 
-export async function createInvoice (userId, { msats, description, descriptionHash, expiry = 360 }, { predecessorId, models, lnd }) {
+export async function createInvoice (userId, { msats, description, descriptionHash, expiry = 360, supportBolt12 = true }, { predecessorId, models, lnd }) {
   // get the wallets in order of priority
   const wallets = await getInvoiceableWallets(userId, { predecessorId, models })
 
@@ -74,6 +74,7 @@ export async function createInvoice (userId, { msats, description, descriptionHa
       }
 
       if (!isBolt12Offer(invoice)) {
+        if (!supportBolt12) continue
         checkInvoice(invoice, { msats }, { lnd, logger })
       }