fix: uncaught promise on getOS causes event to end early

stackernews · Jan 18, 2025 · 1cbf5ab · 1cbf5ab
1 parent a895a91
commit 1cbf5ab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sw/eventListener.js b/sw/eventListener.js
@@ -236,7 +236,7 @@ export function onMessage (sw) {
       messageChannelPort = event.ports[0]
     }
     log('[sw:message] received message', 'info', { action: event.data.action })
-    const currentOS = await getOS()
+    const currentOS = event.waitUntil(getOS())
     log('[sw:message] stored os: ' + currentOS, 'info', { action: event.data.action })
     if (event.data.action === STORE_SUBSCRIPTION) {
       log('[sw:message] storing subscription in IndexedDB', 'info', { endpoint: event.data.subscription.endpoint })
@@ -253,8 +253,8 @@ export function onMessage (sw) {
       promises.push(sw.registration.getNotifications().then((notifications) => {
         notifications.forEach(notification => notification.close())
       }))
-      activeCount = 0
       promises.push(clearAppBadge(sw))
+      activeCount = 0
       event.waitUntil(Promise.all(promises))
     }
   }