Fix gencopy path for external protos

cmd/gencopy/gencopy.bash.in

@@ -11,7 +11,12 @@ CONFIG_SHORT_PATH=@@CONFIG_SHORT_PATH@@
 
 # env
 # set -x
+# echo "PWD: $PWD"
 # find .
+# find ..
+
+# Get the directory of the current script (part of the runfiles tree)
+script_dir=$(dirname "$0")
 
 # find_runfile prints the location of a runfile in the source workspace,
 # either by reading the symbolic link or reading the runfiles manifest.
@@ -45,18 +50,18 @@ fi
 # Note that we don't change directories first; if we did, Generator wouldn't be
 # able to find runfiles, and some extensions rely on that. Generator can use
 # BUILD_WORKSPACE_DIRECTORY to interpret relative paths on the command line.
-GENCOPY_short_path=$(find_runfile "$GENCOPY_SHORT_PATH")
-if [ -z "$GENCOPY_short_path" ]; then
+GENCOPY_path=$(find_runfile "$GENCOPY_SHORT_PATH")
+if [ -z "$GENCOPY_path" ]; then
   echo "error: could not locate gencopy binary" >&2
   exit 1
 fi
 
-CONFIG_short_path=$(find_runfile "$CONFIG_SHORT_PATH")
-if [ -z "$CONFIG_short_path" ]; then
+CONFIG_path=$(find_runfile "$CONFIG_SHORT_PATH")
+if [ -z "$CONFIG_path" ]; then
   echo "error: could not locate gencopy configuration file" >&2
   exit 1
 fi
 
-"$GENCOPY_short_path" \
-  -config="$CONFIG_short_path" \
+"$GENCOPY_path" \
+  -config="$CONFIG_path" \
   -workspace_root_directory="${BUILD_WORKSPACE_DIRECTORY:-""}"

cmd/gencopy/gencopy.bzl

@@ -47,7 +47,7 @@ def gencopy_config(ctx):
     )
 
 def gencopy_action(ctx, config, runfiles):
-    """gencopy_action declared a bazel action that runs the gencopy.bash script.
+    """gencopy_action declares a bazel action that runs the gencopy.bash script.
 
     Args:
         ctx: the context object.

cmd/gencopy/gencopy.go

@@ -11,7 +11,6 @@ import (
 	"os"
 	"path/filepath"
 	"strconv"
-	"strings"
 
 	"github.com/google/go-cmp/cmp"
 )
@@ -174,7 +173,6 @@ func makePkgSrcDstPairs(cfg *Config, pkg *PackageConfig) []*SrcDst {
 
 func makePkgSrcDstPair(cfg *Config, pkg *PackageConfig, src, dst string) *SrcDst {
 	if pkg.TargetWorkspaceRoot != "" {
-		src = filepath.Join("external", strings.TrimPrefix(src, ".."))
 		dst = filepath.Join(pkg.TargetWorkspaceRoot, dst)
 	}
 	dst = filepath.Join(cfg.WorkspaceRootDirectory, dst)

cmd/gencopy/gencopy_test.go

@@ -68,7 +68,7 @@ func TestMakePkgSrcDstPair(t *testing.T) {
 			pkg:  PackageConfig{TargetWorkspaceRoot: "external/foo"},
 			src:  "../foo/file.txt",
 			dst:  "file.txt",
-			want: SrcDst{Src: "external/foo/file.txt", Dst: "/home/external/foo/file.txt"},
+			want: SrcDst{Src: "../foo/file.txt", Dst: "/home/external/foo/file.txt"},
 		},
 	} {
 		t.Run(name, func(t *testing.T) {

pkg/protoc/proto_compiled_sources.go

@@ -44,6 +44,9 @@ func (s *protoCompiledSources) LoadInfo() rule.LoadInfo {
 
 // ProvideRule implements part of the LanguageRule interface.
 func (s *protoCompiledSources) ProvideRule(cfg *LanguageRuleConfig, config *ProtocConfiguration) RuleProvider {
+	if len(config.Outputs) == 0 {
+		return nil
+	}
 	return &protoCompileRule{
 		kind:            "proto_compiled_sources",
 		nameSuffix:      "compiled_sources",

rules/private/proto_repository_tools_srcs.bzl

@@ -181,6 +181,7 @@ PROTO_REPOSITORY_TOOLS_SRCS = [
     "@build_stack_rules_proto//plugin/grpc/grpc-web:BUILD.bazel",
     "@build_stack_rules_proto//plugin/grpc-ecosystem/grpc-gateway:BUILD.bazel",
     "@build_stack_rules_proto//plugin/scalapb/scalapb:BUILD.bazel",
+    "@build_stack_rules_proto//plugin/scalapb/zio-grpc:BUILD.bazel",
     "@build_stack_rules_proto//plugin/stackb/grpc_js:BUILD.bazel",
     "@build_stack_rules_proto//plugin/stephenh/ts-proto:BUILD.bazel",
     "@build_stack_rules_proto//rules:BUILD.bazel",