Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group feed ad should be encrypted to self too #15

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Group feed ad should be encrypted to self too #15

merged 2 commits into from
Feb 22, 2023

Conversation

Powersource
Copy link
Contributor

for ssbc/ssb-tribes2#40

this change has already been done in tribes2 in ssbc/ssb-tribes2#44

@Powersource Powersource requested review from staltz and mixmix February 9, 2023 09:31
@Powersource Powersource mentioned this pull request Feb 9, 2023
Closed
6 tasks
staltz
staltz approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will need a spec version bump afterwards

mixmix
mixmix requested changes Feb 12, 2023
View reviewed changes
Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would benefit from saying what this means?
i.e. do we mean "own_key", something else.... or left to the reader

@Powersource Powersource requested a review from mixmix February 17, 2023 13:51
@Powersource Powersource merged commit 3042149 into main Feb 22, 2023
@Powersource Powersource deleted the Powersource-patch-1 branch February 22, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixmix mixmix mixmix approved these changes

@staltz staltz staltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Powersource @staltz @mixmix