Fetch Argo workflow logs #1332
Fetch Argo workflow logs #1332
Conversation
tonyyang-svail
changed the title
| return string(output), nil | ||
| } | ||
|
|
||
| func getPodLogs(podName string) (string, error) { |
There was a problem hiding this comment.
kubectl logs would fetch all the logs, please add a TODO comment here to implement fetch logs by an incremental way.
There was a problem hiding this comment.
Sure, I will add this in the next PR.
| @@ -163,6 +164,16 @@ func writeArgoFile(coulerFileName string) (string, error) { | |||
| return argoYaml.Name(), nil | |||
| } | |||
|
|
|||
| func getWorkflowID(output string) (string, error) { | |||
There was a problem hiding this comment.
Duplicated with workflow.go#getWorkflowID ?
There was a problem hiding this comment.
Yes, I will move workflow related code to package workflow in the next PR.
| } | ||
|
|
||
| func getWorkflowStatusPhase(job pb.Job) (string, error) { | ||
| cmd := exec.Command("kubectl", "get", "wf", job.Id, "-o", "jsonpath={.status.phase}") |
There was a problem hiding this comment.
can we use https://github.com/kubernetes/client-go instead of calling the command line?
There was a problem hiding this comment.
What is the advantage of using the client-go? I am not sure if the client-go supports parsing the Argo workflow descriptions, so I may need to spend some time to test it out.
There was a problem hiding this comment.
I created an issue: #1362 to discuss go-client or kubectl, maybe we can move to make some disccusion.
Part of #1066.
Next step: