Submit Argo workflow #1252
Merged
Submit Argo workflow #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
requested review from
typhoonzero,
tonyyang-svail,
shendiaomo and
weiguoz
typhoonzero
previously approved these changes
Nov 26, 2019
| @@ -81,6 +85,7 @@ func main() { | |||
| caCrt := flag.String("ca-crt", "", "CA certificate file.") | |||
| caKey := flag.String("ca-key", "", "CA private key file.") | |||
| port := flag.Int("port", 50051, "TCP port to listen on.") | |||
| isArgoMode := flag.Bool("argo-mode", false, "Enable Argo workflow model.") | |||
There was a problem hiding this comment.
maybe also need to configure the k8s API endpoint address in the future?
There was a problem hiding this comment.
Good point and I will add it when implementing the Fetch interface.
| // | ||
| // 1. Local model |
There was a problem hiding this comment.
will the "local mode" move to couler "docker mode"?
There was a problem hiding this comment.
The local mode here is the current implementation. Will move to docker mode if the docker mode is ready in Couler.
| @@ -82,6 +78,9 @@ func (s *Server) Run(req *pb.Request, stream pb.SQLFlow_RunServer) error { | |||
| res, err = encodeRow(s) | |||
| case string: | |||
| res, err = encodeMessage(s) | |||
| case sf.WorkflowJob: | |||
| job := r.(sf.WorkflowJob) | |||
| res = &pb.Response{Response: &pb.Response_Job{Job: &pb.Job{Id: job.JobID}}} | |||
There was a problem hiding this comment.
If you also update the pysqlflow, please refer to this PR in the pysqlflow PR.
There was a problem hiding this comment.
Sure, there is a task in the TODO list #1066
…o submit_interface
typhoonzero
approved these changes
Nov 26, 2019
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1066, add
SubmitWorkflowimplement ofRuninterface to callcodegen_couler.go.TODO:
codegen_couler.go