Deprecate ConditionOutcome.inverse() #43739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quaff
commented
Jan 9, 2025
quaff
commented
- It's not used anywhere.
- The condition message is not applicable for reusing if match is reversed in practice.
- The method is not doing much, we should call the constructor directly since it is public.
- It's better to define it as instance method if it indeed required.
spring-projects-issues
added
the
status: waiting-for-triage
1. It's not used anywhere. 2. The condition message is not applicable for reusing if match is reversed in practice. 3. The method is not doing much, we should call the constructor directly since it is public. 4. It's better to define it as instance method if it indeed required. Signed-off-by: Yanming Zhou <[email protected]>
philwebb
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.