Extend Http base class with config interface and add optional chaining to the Client #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letelete
force-pushed
the
fluent-interface
branch
from
81ea3cf to
529f8eb
Compare
letelete
changed the title
letelete
force-pushed
the
fluent-interface
branch
from
529f8eb to
7866580
Compare
letelete
force-pushed
the
fluent-interface
branch
from
7866580 to
a478101
Compare
letelete
force-pushed
the
fluent-interface
branch
from
e89687b to
3a393a9
Compare
rafalcymerys
reviewed
Oct 3, 2022
| public async accountInfo(options: AccountInfoOptions): Promise<IAccountResult> | ||
| export default class Account<ClientOptions extends AllowedClientBuilderOptions> extends Http { | ||
| public async contractTest(options: AccountContractTestOptions<ClientOptions>): Promise<string> { | ||
| return options.locale ?? 'asd' |
There was a problem hiding this comment.
@letelete this seems like a leftover from local testing ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for implementing fluent interface experience provided by the SDK.
Chained methods (withLocale) are optional, don't break usage of the SDK, and are backward compatible.
Moreover, a configuration can be overridden on endpoint calls by passing particular params (eg. locale).
This proposal suggests a base PoC for refactoring the SDK and enabling the user to provide initial configuration on the
makeClientfunction call level such as Bearer token, Currency, and more...