New benchmarks in java #222

mahlashrifi · 2024-10-17T18:33:54Z

Hi,
I hope you are doing well. I have made a pull request to clarify which parts are unnecessary and which parts need to be added.
This pull request contains three components:

1- Completion of Java support for benchmarking on OpenWhisk (when the fat jar, including wrapper and source code, is less than 48 MB).
The initial commits are included in this pull request.

2- Two new benchmarks:
Training function of TeaStore
CheckLogin benchmark of TeaStore

3- Six additional benchmarks that are essentially variations of CheckLogin with different dependencies. I noticed something called "payload" in the results of running SeBS benchmarks, but I wasn’t sure how to use it. These six benchmarks were meant to serve as examples for using our implementation. My intention was to test whether the jar file size directly affects the delay in running serverless functions, but I found no significant impact.
The attached diagram and summarized information provide further details. I believe that if we can set the payload in SeBS, these additional codes can be omitted.

…erless-benchmarks into java_benchmarks_support

.vscode/launch.json

mcopik · 2024-12-20T21:17:05Z

out_storage.json

@@ -0,0 +1,10 @@
+{


This also should be deleted

You are right! Deleted. Thanks. Should files like these be added to .gitignore or not? I am asking to understand best practices."

You can add the entire .vscode directory to the gitignore :-)

mcopik · 2024-12-20T21:18:06Z

sebs/openwhisk/openwhisk.py

@@ -168,7 +168,7 @@ def build_base_image(
        )

        for fn in os.listdir(directory):
-            if fn not in ("index.js", "__main__.py", "Main.java"):
+            if fn not in ("index.js", "__main__.py"):


Why is the .java fil deleted now?

Because Main.java is now in the same directory as the other files. They are all part of a Maven project and have been packaged into a fat jar for deployment on OpenWhisk. For functions larger than 48 MB, I think I will need to add Main.java again.

sebs/openwhisk/openwhisk.py

config/systems.json

config/login-checker-config.json

config/example.json

mcopik · 2024-12-20T21:24:52Z

benchmarks/wrappers/openwhisk/java/Main.java

-        jsonObject.put("compute_time", computeTime);
-        jsonObject.put("is_cold", isCold);
-        jsonObject.put("result", result);
+        jsonResult.addProperty("begin", formattedBegin); 


I'm curious - what's the difference here :-)?

mcopik · 2024-12-20T21:26:51Z

benchmarks/600.java/602.login-checker/config.json

@@ -0,0 +1,6 @@
+{
+    "timeout": 60,
+    "memory": 24,


this doesn't appear to be a correct value - is it really just 24 MB?

mcopik · 2024-12-20T21:42:13Z

@mahlashrifi Few comments in addition to the review :-)

I'm a bit confused about the directory structure: why some many folders look the same and are named benchmark${i}?
We should annotate the code from TrainTicket benchmark with their original license - we should add in the beginning of the file the contents of their Apache license + copyright of original authors.
We should create a separate directory for the whole microservice - but let's discuss it once we resolve other issues :)

coderabbitai · 2024-12-25T20:48:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mahlashrifi and others added 5 commits September 25, 2024 19:06

making jar file is working correctly

aab419d

loginChecker running successfly on openwhisk

a80e91f

Update config.json

686b536

Add all codes

4f24bd3

Merge branch 'java_benchmarks_support' of github.com:mahlashrifi/serv…

c019089

…erless-benchmarks into java_benchmarks_support

mahlashrifi changed the title ~~Java benchmarks support~~ New benchmarks in java Oct 17, 2024

mahlashrifi mentioned this pull request Oct 17, 2024

Java benchmarks support #223

Open

mcopik requested changes Dec 20, 2024

View reviewed changes

Remove .vscode folder from the repository and add it to .gitignore

a6ec3f5

mahlashrifi added 5 commits December 26, 2024 00:28

Removed out_storage.json

fbc34a8

Refactored OpenWhisk run command handling for Java functions

29e3529

Removed repo name from system.json file

1a1a647

Removed config files mistakenly committed.

4e997ef

Reverted config file to remove unintended changes.

fbeaa89

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New benchmarks in java #222

New benchmarks in java #222

mahlashrifi commented Oct 17, 2024 •

edited

Loading

mcopik Dec 20, 2024

mahlashrifi Dec 25, 2024

mcopik Dec 29, 2024

mcopik Dec 20, 2024

mahlashrifi Dec 26, 2024

mcopik Dec 20, 2024

mcopik Dec 20, 2024

mcopik commented Dec 20, 2024

coderabbitai bot commented Dec 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

New benchmarks in java #222

Are you sure you want to change the base?

New benchmarks in java #222

Conversation

mahlashrifi commented Oct 17, 2024 • edited Loading

mcopik Dec 20, 2024

Choose a reason for hiding this comment

mahlashrifi Dec 25, 2024

Choose a reason for hiding this comment

mcopik Dec 29, 2024

Choose a reason for hiding this comment

mcopik Dec 20, 2024

Choose a reason for hiding this comment

mahlashrifi Dec 26, 2024

Choose a reason for hiding this comment

mcopik Dec 20, 2024

Choose a reason for hiding this comment

mcopik Dec 20, 2024

Choose a reason for hiding this comment

mcopik commented Dec 20, 2024

coderabbitai bot commented Dec 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mahlashrifi commented Oct 17, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)