Improved model for MIRI cruciform artifact, part 2

[mperrin]

This is the second portion of an improved model for the MIRI cruciform artifacts, began in #837 . This PR should stay draft and not be merged until after #837 is merged; this branch is branched off of the PR #837 branch. Besides it's still more of a work in progress.

This PR adds an attempt at modeling the peaks or bumps within the cruciform, as predicted in Gaspar et al. 2021. See their Figure 12 in particular.

I have attempted to take the values stated in section 4.3 of that paper, for the m=4 to 10 order peaks, and apply some scale factors to get models of those in webbpsf, and tune a bit to match the empirical PSFs. This is complex and messy however because the physics is very complex, there are many free parameters in this ad hoc parameterizatation, and the available MIRI ePSFs are of modest SNR. Not sure how tractable this is; for now it's a work in progress.

Motivated in part by seeking to understand the complex diffractive structure seen in dispersed LRS PSFs at short wavelengths.

Examples

• Data: miri_epsfs_F560W_measured.pdf
• With PR Improved model for MIRI cruciform artifact, part 1 #837: miri_epsfs_F560W_sim_new.pdf
• with this PR: miri_epsfs_F560W_sim_new_v2.pdf

[pep8speaks]

Hello @mperrin, Thank you for updating !

• In the file webbpsf/constants.py:

Line 407:36: E262 inline comment should start with '# '
Line 408:31: E226 missing whitespace around arithmetic operator
Line 408:42: E241 multiple spaces after ','
Line 408:126: E501 line too long (154 > 125 characters)
Line 409:126: E501 line too long (152 > 125 characters)
Line 410:126: E501 line too long (127 > 125 characters)
Line 410:128: W291 trailing whitespace

• In the file webbpsf/detectors.py:

Line 63:9: E266 too many leading '#' for block comment
Line 63:126: E501 line too long (149 > 125 characters)
Line 170:126: E501 line too long (128 > 125 characters)
Line 286:126: E501 line too long (126 > 125 characters)
Line 287:68: E231 missing whitespace after ','
Line 287:72: E231 missing whitespace after ','
Line 288:68: E231 missing whitespace after ','
Line 288:70: E231 missing whitespace after ','
Line 290:1: E302 expected 2 blank lines, found 1
Line 313:16: E226 missing whitespace around arithmetic operator
Line 314:26: E201 whitespace after '('
Line 316:5: E266 too many leading '#' for block comment
Line 316:60: W291 trailing whitespace
Line 319:15: E226 missing whitespace around arithmetic operator
Line 319:18: E226 missing whitespace around arithmetic operator
Line 336:86: W291 trailing whitespace
Line 343:126: E501 line too long (132 > 125 characters)
Line 349:126: E501 line too long (158 > 125 characters)
Line 349:159: W291 trailing whitespace
Line 350:41: E226 missing whitespace around arithmetic operator
Line 350:63: E226 missing whitespace around arithmetic operator
Line 350:96: E226 missing whitespace around arithmetic operator
Line 350:118: E226 missing whitespace around arithmetic operator
Line 351:41: E226 missing whitespace around arithmetic operator
Line 351:63: E226 missing whitespace around arithmetic operator
Line 351:96: E226 missing whitespace around arithmetic operator
Line 351:118: E226 missing whitespace around arithmetic operator
Line 354:27: E226 missing whitespace around arithmetic operator
Line 355:27: E226 missing whitespace around arithmetic operator
Line 358:37: E226 missing whitespace around arithmetic operator
Line 359:40: E226 missing whitespace around arithmetic operator
Line 361:5: E266 too many leading '#' for block comment
Line 364:19: E226 missing whitespace around arithmetic operator
Line 364:32: E226 missing whitespace around arithmetic operator
Line 365:16: E221 multiple spaces before operator
Line 365:29: E226 missing whitespace around arithmetic operator
Line 365:31: E226 missing whitespace around arithmetic operator
Line 366:20: E127 continuation line over-indented for visual indent
Line 399:50: E127 continuation line over-indented for visual indent
Line 399:106: E251 unexpected spaces around keyword / parameter equals
Line 399:108: E251 unexpected spaces around keyword / parameter equals
Line 402:5: E303 too many blank lines (2)
Line 515:9: E128 continuation line under-indented for visual indent
Line 515:27: E251 unexpected spaces around keyword / parameter equals
Line 516:19: E251 unexpected spaces around keyword / parameter equals
Line 516:21: E251 unexpected spaces around keyword / parameter equals
Line 516:51: E226 missing whitespace around arithmetic operator
Line 516:55: E202 whitespace before ')'
Line 536:85: E231 missing whitespace after ','
Line 541:33: E226 missing whitespace around arithmetic operator
Line 541:50: E226 missing whitespace around arithmetic operator
Line 543:13: E225 missing whitespace around operator
Line 543:19: E226 missing whitespace around arithmetic operator
Line 543:27: E226 missing whitespace around arithmetic operator
Line 543:36: E226 missing whitespace around arithmetic operator
Line 543:44: E226 missing whitespace around arithmetic operator
Line 546:9: E128 continuation line under-indented for visual indent
Line 546:27: E251 unexpected spaces around keyword / parameter equals
Line 554:14: E231 missing whitespace after ','
Line 554:16: E231 missing whitespace after ','
Line 557:1: W391 blank line at end of file

Comment last updated at 2024-05-17 18:47:32 UTC

[mperrin]

FYI @merope82

[mperrin]

Future development and implementation of this PR has migrated to spacetelescope/stpsf#52