Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for V VW CHA A and B components #128

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add metadata for V VW CHA A and B components #128

merged 4 commits into from
Dec 6, 2023

Conversation

jotaylor
Copy link
Collaborator

@jotaylor jotaylor commented Dec 5, 2023

The non-GAIA metadata came from Will offline. I looked up the GAIA information using the GAIA IDs on Simbad.

@jotaylor jotaylor added alias Relates to the alias data database labels Dec 5, 2023
Copy link
Contributor

@Rplesha Rplesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the calibration database file been run with this branch? I'll also need to run the website code with this update to make sure no PIDs are missing.

Copy link
Collaborator

@wfischer-stsci wfischer-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For VW Cha A, the rate_accretion_ref column should have 2013A&A...554A..43D

@jotaylor
Copy link
Collaborator Author

jotaylor commented Dec 6, 2023

Has the calibration database file been run with this branch? I'll also need to run the website code with this update to make sure no PIDs are missing.

Oops no. I don't think it should change anything since these are essentially "companions", but they're TTS so we want to deliver them. I will run it now regardless 👍

@Rplesha
Copy link
Contributor

Rplesha commented Dec 6, 2023

@jotaylor I will run this branch on the TTS part of the website code now with your new changes and let you know if I need any additional changes

@jotaylor
Copy link
Collaborator Author

jotaylor commented Dec 6, 2023

Sorry, I realized I didn't include much background info for these 2 new targets. We have AR data for the TTS VW Cha, but in fact that "star" is actually a complicated multiple system. Two of the components, A and B, are sometimes resolved in some of the AR data, depending on the orientation of the slit. Sometimes they are separated in the dispersion direction and are therefore unresolved. For unresolved observations, we extract the source as v-vw-cha. For resolved observations, we extract as v-vw-chaa and v-vw-chab. So for the purposes of the website, v-vw-chaa and v-vw-chab basically count as "companions", even though they are both TTS of interest. The similar case is CVSO-165A, CVSO-165B, and CVSO-165. So, the end result is that these new additions should not appear on the website (just as we only have CVSO-165 on the website).

Hopefully this makes sense!

@wfischer-stsci
Copy link
Collaborator

I just randomly remembered that this issue is discussed in Section 2.3.2 of this paper

@jotaylor
Copy link
Collaborator Author

jotaylor commented Dec 6, 2023

@Rplesha I ran the write_calibration_db.py script and there were no changes. I think this makes sense, since these 2 targets will be extracted from FLTs of an existing target/dataset (v-vw-cha) 👍

Copy link
Contributor

@Rplesha Rplesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes on the website either, as expected from what you just said!

Should we link in the DR notes to the paper that Will just pointed to?

@jotaylor
Copy link
Collaborator Author

jotaylor commented Dec 6, 2023

No changes on the website either, as expected from what you just said!

Should we link in the DR notes to the paper that Will just pointed to?

Yes, good call. And probably another paper he sent me: https://iopscience.iop.org/article/10.3847/1538-4357/ac7229

Copy link
Collaborator

@wfischer-stsci wfischer-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is well

@jotaylor jotaylor merged commit fa14545 into main Dec 6, 2023
1 check passed
@jotaylor jotaylor deleted the vw_cha branch December 6, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alias Relates to the alias data database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants