Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Log records patch" #175

Closed
wants to merge 1 commit into from
Closed

Revert "Log records patch" #175

wants to merge 1 commit into from

Conversation

braingram
Copy link
Collaborator

Reverts #174

@braingram braingram requested a review from a team as a code owner July 30, 2024 15:36
@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Jul 30, 2024 •
edited
Loading

we could also rebase the release/0.6.x branch to drop that commit (13f74f7), to keep the commit history clean

@braingram braingram added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Jul 30, 2024
@braingram
Copy link
Collaborator Author

we could also rebase the release/0.6.x branch to drop that commit, to keep the commit history clean

Good idea! I was lazy and clicked the 'revert' button on github :)

@braingram braingram deleted the revert-174-log_records_patch branch July 30, 2024 15:39
@zacharyburnett
Copy link
Collaborator

ok, commit dropped

@braingram braingram mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @zacharyburnett