-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3623: Catch Runtime warnings in jump step #258
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 85.18% 85.00% -0.19%
==========================================
Files 35 35
Lines 6797 6867 +70
==========================================
+ Hits 5790 5837 +47
- Misses 1007 1030 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change log. Also, is it possible to add a CI test to ensure tests are being reported (or not) as expected?
Not sure how to add a test for error messages from these specific locations, but have added a change log entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
Closing and reopening to trigger CI tests. |
Resolves JP-3623 by catching a few runtime warnings in the jump step that were no longer caught after recent updates.
Closes spacetelescope/jwst#8483
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)