Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changlog CI to use a pre-built workflow. #233

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

This PR updates the CI to use a pre-built changelog workflow, which is functionally equivalent to the current one

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d44cd8) 84.31% compared to head (5ec670d) 84.31%.

❗ Current head 5ec670d differs from pull request most recent head 20eeeec. Consider uploading reports for the commit 20eeeec to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files          35       35           
  Lines        6452     6452           
=======================================
  Hits         5440     5440           
  Misses       1012     1012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor tweaks to minimize changes to the PR check screen

.github/workflows/changelog.yml Outdated Show resolved Hide resolved
.github/workflows/changelog.yml Outdated Show resolved Hide resolved
.github/workflows/changelog.yml Outdated Show resolved Hide resolved
@zacharyburnett
Copy link
Collaborator

looks like it's sticking up on the changelog format:

docutils.utils.SystemMessage: <rst-doc>:272: (SEVERE/4) Title level inconsistent:

ramp_fitting
~~~~~~~~~~~~

I'll go through an fix these

@zacharyburnett
Copy link
Collaborator

looks like that fixed it; I just used restructuredtext-lint to find issues

pip install restructuredtext-lint
restructuredtext-lint CHANGES.txt

@zacharyburnett zacharyburnett merged commit 5756fda into spacetelescope:main Dec 6, 2023
21 checks passed
@WilliamJamieson WilliamJamieson deleted the ci/update_changelog branch February 13, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants