Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mwregan2 committed Jun 4, 2024
1 parent 8a44a3e commit ebafdea
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 24 deletions.
3 changes: 1 addition & 2 deletions src/stcal/jump/jump.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

from . import constants
from . import twopoint_difference as twopt
from astropy.io import fits

log = logging.getLogger(__name__)
log.setLevel(logging.DEBUG)

Expand Down Expand Up @@ -465,7 +465,6 @@ def detect_jumps(

# This is the flag that controls the flagging of snowballs.
if expand_large_events:
# fits.writeto("ingdq.fits", gdq)
gdq, total_snowballs = flag_large_events(
gdq,
jump_flag,
Expand Down
2 changes: 1 addition & 1 deletion src/stcal/ramp_fitting/ols_fit.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import numpy as np

#from .slope_fitter import ols_slope_fitter # c extension
from .slope_fitter import ols_slope_fitter # c extension
from . import ramp_fit_class, utils


Expand Down
21 changes: 0 additions & 21 deletions tests/test_jump.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,27 +547,6 @@ def test_inside_ellipes5():
result = point_inside_ellipse(point, ellipse)
assert result

@pytest.mark.skip(" used for local testing")
def test_flag_persist_groups():
# gdq = fits.getdata("persistgdq.fits")
gdq = fits.getdata("../../../notebooks/ingdq.fits")
# gdq = hdul['GROUPDQ'].data
print(gdq.shape)
# gdq = gdq[:, 0:10, :, :]
gdqout, total_snowballs = flag_large_events(
gdq,
DQFLAGS["JUMP_DET"],
DQFLAGS["SATURATED"],
min_sat_area=1,
min_jump_area=6,
expand_factor=1.9,
edge_size=0,
sat_required_snowball=True,
min_sat_radius_extend=2.5,
sat_expand=1.1,
mask_persist_grps_next_int=True,
persist_grps_flagged=0)
fits.writeto("../../../notebooks/gdqout.fits", gdqout, overwrite=True)
def test_calc_num_slices():
n_rows = 20
max_available_cores = 10
Expand Down

0 comments on commit ebafdea

Please sign in to comment.