Add WCS to schemas #351
Merged
Add WCS to schemas #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nden
requested review from
kdupriestsci,
jbrookens,
WilliamJamieson and
a team
as code owners
braingram
reviewed
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 4 4
Lines 171 171
=======================================
Hits 163 163
Misses 8 8 ☔ View full report in Codecov by Sentry. |
|
Passing regression tests |
WilliamJamieson
requested changes
Jan 16, 2024
Comment on lines
+21
to
+23
| anyOf: | ||
| - tag: tag:stsci.edu:gwcs/wcs-* | ||
| - type: "null" |
There was a problem hiding this comment.
Why is this null? It is not a required field by the object.
There was a problem hiding this comment.
Thanks for pointing this out. It needs to be a required field.
There was a problem hiding this comment.
Should it still be null, or do we always expect a gwcs object in the end?
6 tasks
WilliamJamieson
approved these changes
Jan 22, 2024
|
Merging - assuming this doesn't need to be approved for the database team |
stscieisenhamer
pushed a commit
to stscieisenhamer/rad
that referenced
this pull request
Jan 23, 2024
* add a WCS object to schemas * using gwcs schemas * add gwcs tag to valid schemas * use 1.0.0 version of the wcs tag * fix test * add another wcs tag * use wild card with wcs schema * fix test_schema * add a change log * another fix for tesst_schemas * make wcs required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RCAL-749
Closes #
This PR addresses ...
Checklist
CHANGES.rstunder the corresponding subsection