Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'colab' and 'binder' with 'Jupyterhub' in 'Launch' menu #54

Closed
wants to merge 1 commit into from

Conversation

dulude
Copy link
Collaborator

@dulude dulude commented Oct 27, 2023

Relevant Tickets and PRs

High-Level Summary

  • The issue with mast_notebooks/ content not launching in TIKE was found to be a server-side issue that could be solved by removing an existing clone of the mast_notebooks in the virtual environment and that the changes in PR Reverted changes from PR #51 #52 could be reverted.

Summary of Changes

  • Returned the launch buttons section of the _config.yml file back to the state post-PR Refactor notebook "Launch menu" items #51 merge.
    • Commented out 'binderhub_url' and 'colab_url' params in _config.yml.
    • Uncommented 'jupyterhub', 'jupyterhub_url' and 'notebook_interface' params in _config.yml.
  • Commented out the 'path_to_book' param in _config.yml.
    • It was contaminating the URL used to launch notebooks in binder and colab leading to "notebook not found" errors.

@dulude dulude added the enhancement New feature or request label Oct 27, 2023
@dulude dulude requested a review from ttdu October 27, 2023 14:57
@dulude dulude self-assigned this Oct 27, 2023
@dulude dulude closed this Oct 27, 2023
@dulude dulude deleted the ununupdate_launch_button branch October 27, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant