Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bandit workflow option #21

Merged
merged 1 commit into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/bandit-schedule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ jobs:
id: bandit-run
run: bandit --format sarif -o results.sarif --confidence-level high --severity-level high -r .

- name: Upload sarif to security
- name: Upload sarif artifact to security
if: ${{ failure() }}
uses: github/codeql-action/upload-sarif@v3
with:
sarif-file: results.sarif
sarif_file: results.sarif


7 changes: 4 additions & 3 deletions .github/workflows/bandit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,14 @@ jobs:
if: ${{ steps.get-changed-notebooks.outputs.any_changed == 'true' }}
env:
ADDED_FILES: ${{ steps.get-changed-notebooks.outputs.all_changed_files }}
run: jupyter nbconvert --allow-errors --sanitize-html --to script $ADDED_FILES

run: |
jupyter nbconvert --allow-errors --sanitize-html --to script $ADDED_FILES

- name: Perform Bandit Analysis
id: bandit-run
run: bandit --format json -o $BANDIT_ARTIFACT --confidence-level high --severity-level high -r .

- name: Upload artifact
- name: Upload bandit artifact for PR review
if: ${{ failure() }}
uses: actions/upload-artifact@v4
with:
Expand Down