-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust view image and view exposure to allow for larger preview images #1600
Adjust view image and view exposure to allow for larger preview images #1600
Conversation
…00pct is about the best you can do
From testing using the current preview images, as well as the new preview images from #1592, the values to use for the image widths: view_exposure: So it probably makes sense to keep the widths in view_exposure set to 100% (which is what they are set to already) under the assumption that eventually all programs will have the newer preview images created from #1592 For view_image, 1000rem seems reasonable, at least in terms of size. Good test cases when working in the nircam test account: |
@mfixstsci @BradleySappington I think this is ready for review. My CSS is weak, so I'm not sure if there is a better way to do what I've done here. I basically made a copy of the margin settings from the Dashboard page and applied them to the image level and exposure level pages. |
Note that in the case of a very narrow but tall preview image, these changes make the preview image quite large. But that actually makes it a lot easier to see what's going on in such a small subarray. Example case when running on the nircam development account: http://127.0.0.1:8000/NIRISS/jw01538065001_02107_00004_nis/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bhilbert4 I just checked the preview images linked in the comment and they look good.
Resolves #1584 (JWQL-214)
Based on feedback from the user survey.
Make preview images larger, to allow for easier QL checks.