Stop storing absolute paths in the database #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @york-stsci, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2023-12-18 15:19:00 UTC |
|
The above is the database update script (named as a text file, because GitHub apparently can't handle the upload of a .py file) |
mfixstsci
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
@york-stsci thanks for the updates! We will need to perform similar updates to #1152. Have the databases been updated yet?
jwql/website/apps/jwql/monitor_pages/monitor_readnoise_bokeh.py
Outdated
Show resolved
Hide resolved
|
The script has not yet been run in active mode. I’m saving that until after we review everything. |
BradleySappington
approved these changes
Dec 18, 2023
This was referenced Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the intent summary is on Jira, but the goal of this PR is to update the readnoise monitor so that it doesn't store absolute paths in the database, and it also doesn't expect absolute paths when run as part of the website.
There will also be an associated script to update the existing database entries that have absolute paths in them.