Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding contrast_sensitivity notebook #324

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

Jackie-Brown
Copy link
Contributor

Adding notebook and supporting files; updating toc.yml, README, and gitignore

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Jackie-Brown
Copy link
Contributor Author

@haticekaratay I'm getting a strange PEP8 error when comparing function keywords to None. If I use keyword == None, the checker raises and error and says I should use keyword is None. But if I use keyword is None, I get both a warning in the notebook itself and in the PEP8 checker saying I should use keyword == None. Do you have any ideas on how to get around this?

@Jackie-Brown Jackie-Brown added Technical Review Notebook is ready for technical review STIS Space Telescope Imaging Spectrograph labels Oct 30, 2024
Copy link
Collaborator

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good on the technical side from me with all tests passing, cheers!

@gibsongreen
Copy link
Collaborator

@haticekaratay I'm getting a strange PEP8 error when comparing function keywords to None. If I use keyword == None, the checker raises and error and says I should use keyword is None. But if I use keyword is None, I get both a warning in the notebook itself and in the PEP8 checker saying I should use keyword == None. Do you have any ideas on how to get around this?

@Jackie-Brown Hey there! The conditions that I saw with the styling were using string literals to test against None. The string literal in the case of 'keyword' will always pass as True since there is at least one character. Instead of using the string literal I used the function parameter for keyword and that then requires the 'is None' instead of '== None'.

@gibsongreen gibsongreen merged commit 31bdcb0 into main Nov 4, 2024
6 checks passed
@gibsongreen gibsongreen deleted the add_contrast_sensitivity_notebook branch November 4, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STIS Space Telescope Imaging Spectrograph Technical Review Notebook is ready for technical review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants