-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding contrast_sensitivity notebook #324
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@haticekaratay I'm getting a strange PEP8 error when comparing function keywords to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good on the technical side from me with all tests passing, cheers!
@Jackie-Brown Hey there! The conditions that I saw with the styling were using string literals to test against None. The string literal in the case of 'keyword' will always pass as True since there is at least one character. Instead of using the string literal I used the function parameter for keyword and that then requires the 'is None' instead of '== None'. |
Adding notebook and supporting files; updating toc.yml, README, and gitignore