Add pre-commit and implement automatic linting and formatting #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 87.58% 85.41% -2.17%
==========================================
Files 22 22
Lines 3955 3957 +2
==========================================
- Hits 3464 3380 -84
- Misses 491 577 +86 ☔ View full report in Codecov by Sentry. |
|
These do not effect the regression tests: |
nden
reviewed
Jan 6, 2025
I ran the regression tests earlier today on both JWST and Romancal, see #544 (comment) |
nden
approved these changes
Jan 6, 2025
WilliamJamieson
added a commit
to WilliamJamieson/gwcs
that referenced
this pull request
Jan 13, 2025
…spacetelescope#544)" This reverts commit 4e438c6, reversing changes made to 4a5fad4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a proper pre-commit config and implements linting and associated improvements to the code base.