return sql.ErrNotFound if account doesn't exist #6508
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it returned an empty account. Now the error handling decision is left for the caller.
poszu
requested review from
dshulyak,
fasmat,
ivan4th,
acud and
jellonek
as code owners
fasmat
reviewed
Nov 29, 2024
fasmat
approved these changes
Nov 29, 2024
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6508 +/- ##
=======================================
Coverage 79.9% 79.9%
=======================================
Files 353 353
Lines 46517 46534 +17
=======================================
+ Hits 37211 37225 +14
- Misses 7199 7208 +9
+ Partials 2107 2101 -6 ☔ View full report in Codecov by Sentry. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed: |
|
Bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed: |
|
bors merge |
|
Already running a review |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
## Motivation The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
|
Build failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
@poszu I'm just using your PR to check if the new systest is working as expected. |
|
bors try |
tryBuild succeeded: |
OK, but keep in mind that this change might actually be unsound as the systests failed few times in a way they hadn't fail before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The decision how to handle a situation when the queried account doesn't exist should be left to the caller - it's not the responsibility of the code accessing the cache/database.
Description
Previously, it returned an empty account. Now the error handling decision is left for the caller.
Test Plan
Updated tests