Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some wallmount .yml cleanup #34329

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Some wallmount .yml cleanup #34329

wants to merge 9 commits into from
+572 −558

Conversation

kosticia
Copy link
Contributor

@kosticia kosticia commented Jan 9, 2025

About the PR

Wallmount staff become a little bit more standardized.

Why / Balance

Now we have pretty much issues with a wallmounts, like a weird hitboxes of telescreen or screens that can't be deconstructed. It should be fixed, and the first step to create really good wallmounts is a standardization of .yml entity files

Technical details

Only .yml changes, added base wallmount entities and parents for other wallmounts

Requirements

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Jan 9, 2025
@IamVelcroboy
Copy link
Contributor

Hey, beat me to it! I was about to do this in the next day or two. Good on you though. One less thing on my list! 😎

@IamVelcroboy
Copy link
Contributor

If you could add wallmounted rechargers and the mini nanomed. Those 2 items are pretty broken at the moment.

@kosticia
Copy link
Contributor Author

kosticia commented Jan 9, 2025

If you could add wallmounted rechargers and the mini nanomed. Those 2 items are pretty broken at the moment.

Sure, forgot about those one

@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 9, 2025
@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kosticia @IamVelcroboy @lzk228