-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CAS auth strategy #2246
Conversation
Pull Request Test Coverage Report for Build 3354297238Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Can I check what's left for this PR? |
As per discussed offline, this PR is ready and simply blocked by awaiting the tests to be implemented in the corresponding backend PR: source-academy/backend#916. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll merge this first because we'll need some of the refactoring work you've done to implement SAML.
Thanks!
Description
Opening a draft PR for CAS authentication to support the teaching team at UU in the interim. Currently, the frontend only supports the OAuth2 specification.
Im planning to do a proper follow up sometime in Dec '22 before merging this. Or whoever is interested in taking this up, please feel free to let me know too 🙂:
Corresponding backend PR: source-academy/backend#916
Type of change
How to test
TBC
Checklist