-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field for bulk chunk size in flex counter #950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuh-80
previously approved these changes
Nov 18, 2024
@stephenxs , can you add PR description and check the failed test? |
/azpw run Azure.sonic-swss-common |
stephenxs
force-pushed
the
bulk-chunk-size
branch
from
November 25, 2024 09:55
9356bc2
to
7d6765a
Compare
qiluo-msft
previously approved these changes
Dec 2, 2024
Could you link to the HLD PR? |
stephenxs
force-pushed
the
bulk-chunk-size
branch
from
December 4, 2024 13:37
7d6765a
to
3ebd251
Compare
FengPan-Frank
previously approved these changes
Dec 9, 2024
|
stephenxs
dismissed stale reviews from FengPan-Frank, qiluo-msft, and liuh-80
via
December 13, 2024 06:34
f014c72
stephenxs
force-pushed
the
bulk-chunk-size
branch
from
December 13, 2024 06:34
f642875
to
f014c72
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
bulk-chunk-size
branch
from
December 24, 2024 03:19
f014c72
to
a8f7b74
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Added a new field in
FLEX_COUNTER_TABLE
to represent the bulk chunk size and bulk chunk size per counter ID for bulk counter polling.