-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High power class enabling for SFF-8636 modules #521
Open
longhuan-cisco
wants to merge
2
commits into
sonic-net:master
Choose a base branch
from
longhuan-cisco:high_power_class_handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
High power class enabling for SFF-8636 modules #521
longhuan-cisco
wants to merge
2
commits into
sonic-net:master
from
longhuan-cisco:high_power_class_handling
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 521 in repo sonic-net/sonic-platform-common |
/azpw run Azure.sonic-platform-common |
/AzurePipelines run Azure.sonic-platform-common |
Azure Pipelines successfully started running 1 pipeline(s). |
@longhuan-cisco Please help in fixing the built failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add platform common API support for enabling high power class if module's power class is greater or equal to 5 (Refer to SFF-8636 spec
6.2.6 Control Functions (Page 00h, Bytes 86-99)
for byte 93 definition)Motivation and Context
Without enabling high power class for those modules, the module won't operate properly with power output and link won't come up.
How Has This Been Tested?
Verified the module operate with proper power output.
Additional Information (Optional)