gNOI Cold Reboot

[rkavitha-hcl]

Why I did it

Work item tracking

• Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205
• 202211
• 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[kishanps]

@vvolam
@rkavitha-hcl is working on fixing the test failures but otherwise the PR has passed the presubmit checks and ready for integration and review.
Adding @github76543 @qiluo-msft & @hdwhdw as well for review.

[hdwhdw]

Honest question: What does this PR really do? It contains 143 files. Is it just too large for be in a single PR? What if we somehow want to roll it back?

[kishanps]

/azpw run

[kishanps]

/AzurePipelines run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 20429 in repo sonic-net/sonic-buildimage

[kishanps]

@vvolam Can you trigger the pipeline (build & test) to run, seems like I don't have permissions to trigger them ?

[mint570]

/AzurePipelines run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 20429 in repo sonic-net/sonic-buildimage

[vvolam]

/azpw run

[kishanps]

Honest question: What does this PR really do? It contains 143 files. Is it just too large for be in a single PR? What if we somehow want to roll it back?

@hdwhdw Fair question, let me add some high level details here that might help the review. Although there are 143 files, the major changes are related to adding the new framework docker.

1. New changes to add framework docker to the system
2. Inside the framework docker

• rebootbackend process listens for notifications on redis db (gNOI frontend sends notification on any of the reboot set operation) and invokes sonic-host-services for the corresponding method
• Add openconfig gNOI sub-module

[kishanps]

@wangxin Is the pipeline failure in this PR expected given your upcoming changes in PR #20567 ?

[yutongzhang-microsoft]

@wangxin Is the pipeline failure in this PR expected given your upcoming changes in PR #20567 ?

Yes, it is expected.

[hdwhdw]

@kishanps Thanks for the breakdown! Now it makes much more sense.

I can see many of these changes can be in its independent PR, such as one for just introducing an GNOI definition as a submodule (in fact this can benefit a lot more than just the reboot). If those can be in their separate PR we can get them in quickly.

[kishanps]

@kishanps Thanks for the breakdown! Now it makes much more sense.

I can see many of these changes can be in its independent PR, such as one for just introducing an GNOI definition as a submodule (in fact this can benefit a lot more than just the reboot). If those can be in their separate PR we can get them in quickly.

Here are the breakdown PR's

• gNOI Cold Reboot #20558 - Adding the framework docker in the sonic-buildimage
• gNOI Cold Reboot - Integrated Rebootbackend changes #20577 - rebootbackend process code inside the framework docker
• gNOI Cold Reboot - Integrated tests #20586 - Unit tests for cold reboot in rebootbackend
• gNOI Cold Reboot - Integrated gNOI repository #20600 - Adding gNOI submodule as a sub-dir inside framework
• gNOI Cold Reboot - Integrated Docker and Makefile changes #20615 - Enabling framework docker and all Makefile changes

Adding @vvolam, @qiluo-msft for viz.