Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NULL pointer access in systemd-sonic-generator #17720

Conversation

stephenxs
Copy link
Collaborator

Why I did it

Fix NULL pointer access when there is no WantedBy or RequiredBy in the first line.

Signed-off-by: Stephen Sun [email protected]

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Manual and unit test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs stephenxs requested a review from lguohan as a code owner January 9, 2024 13:34
@stepanblyschak
Copy link
Collaborator

@stephenxs Is it the same fix as in #17764 ? It looks the same

@stephenxs
Copy link
Collaborator Author

@stephenxs Is it the same fix as in #17764 ? It looks the same

@stepanblyschak Yes. They are the same. We can keep either.

@stephenxs stephenxs closed this Jan 30, 2024
@stephenxs stephenxs deleted the fix-null-pointer-systemd-sonic-generator branch February 26, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants