Fix NULL pointer access in systemd-sonic-generator

Signed-off-by: Stephen Sun <[email protected]>
sonic-net · Jan 8, 2024 · 57f2e49 · 57f2e49
1 parent c0bc1d9
commit 57f2e49
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/systemd-sonic-generator/systemd-sonic-generator.c b/src/systemd-sonic-generator/systemd-sonic-generator.c
@@ -269,7 +269,7 @@ int get_install_targets(char* unit_file, char* targets[]) {
     char* token;
     char* line = NULL;
     bool first;
-    char* target_suffix;
+    char* target_suffix = NULL;
     char *instance_name;
     char *dot_ptr;
 
@@ -308,7 +308,7 @@ int get_install_targets(char* unit_file, char* targets[]) {
                     target_suffix = ".wants";
                 }
             }
-            else {
+            else if (NULL != target_suffix) {
                 found_targets = get_install_targets_from_line(token, target_suffix, targets, num_targets);
                 num_targets += found_targets;
             }

diff --git a/src/systemd-sonic-generator/tests/testfiles/multi_inst_a.service b/src/systemd-sonic-generator/tests/testfiles/multi_inst_a.service
@@ -6,4 +6,5 @@ StartLimitBurst=3
 User=root
 ExecStop=/usr/bin/test.sh stop
 [Install]
+Alias=alias
 WantedBy=multi-user.target