Skip to content

Commit

Permalink
pass newly named ENV var in build and release process
Browse files Browse the repository at this point in the history
Signed-off-by: Paul Horton <[email protected]>
  • Loading branch information
madpah committed Sep 2, 2024
1 parent 583d2a5 commit 49ebb54
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
uses: docker/build-push-action@v6
with:
build-args: |
CLA_URL=${{ secrets.CLA_URL }}
REACT_APP_CLA_URL=${{ secrets.CLA_URL }}
REACT_APP_COMPANY_NAME=${{ secrets.REACT_APP_COMPANY_NAME }}
REACT_APP_COMPANY_WEBSITE=${{ secrets.REACT_APP_COMPANY_WEBSITE }}
REACT_APP_CLA_APP_NAME=${{ secrets.REACT_APP_CLA_APP_NAME }}
Expand All @@ -67,7 +67,7 @@ jobs:
uses: docker/build-push-action@v5
with:
build-args: |
CLA_URL=${{ secrets.CLA_URL }}
REACT_APP_CLA_URL=${{ secrets.CLA_URL }}
REACT_APP_COMPANY_NAME=${{ secrets.REACT_APP_COMPANY_NAME }}
REACT_APP_COMPANY_WEBSITE=${{ secrets.REACT_APP_COMPANY_WEBSITE }}
REACT_APP_CLA_APP_NAME=${{ secrets.REACT_APP_CLA_APP_NAME }}
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#

FROM node:18-alpine3.18 AS yarn-build
ARG CLA_URL=http://something
ARG REACT_APP_CLA_URL=http://something
ARG REACT_APP_COMPANY_NAME=A Company Name Here
ARG REACT_APP_COMPANY_WEBSITE=http://localhost
ARG REACT_APP_CLA_APP_NAME=CLA App
Expand All @@ -29,7 +29,7 @@ WORKDIR /src

COPY . .

RUN CLA_URL="$CLA_URL" \
RUN REACT_APP_CLA_URL="$REACT_APP_CLA_URL" \
REACT_APP_COMPANY_NAME="$REACT_APP_COMPANY_NAME" \
REACT_APP_COMPANY_WEBSITE="$REACT_APP_COMPANY_WEBSITE" \
REACT_APP_CLA_APP_NAME="$REACT_APP_CLA_APP_NAME" \
Expand Down

0 comments on commit 49ebb54

Please sign in to comment.