Default release namespace for namespaced rbac #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
Instead of altering these templates, why don't we just set defaults in GME's gloo-platform helm chart? Default being the 3 resources we need along with the release namespace for glooUi.namespacedRbac. |
We can't set the release namespace by default in the gloo-platform helm chart - see https://github.com/solo-io/gloo-mesh-enterprise/issues/15739#issuecomment-2313169671 |
jehawley
previously approved these changes
Aug 30, 2024
josh-pritchard
approved these changes
Sep 4, 2024
soloio-bulldozer
bot
deleted the
ashleywang1/default-release-namespace-for-namespaced-rbac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In https://github.com/solo-io/gloo-mesh-enterprise/pull/17198, we added Pods, ConfigMaps, and Secrets to the DashboardInputSnapshot, which caused the gloo-mesh-ui to begin reading all of these resources from all namespaces in the mgmt-cluster. We intended to only allow these resources to be read from the 'gloo-mesh' namespace, but the NamespacedRbac requires you to pass in glooUi.namespacedRbac values in order to activate that feature.
By default, we want to set the glooUi.namespacedRbac.resources values, and no glooUi.namespacedRbac.namespaces value. Then we want to make a skv2 change so that if glooUi.namespacedRbac.namespaces is empty but glooUi.namespacedRbac.resources is not, we default to the Release.Namespace.
BOT NOTES:
resolves https://github.com/solo-io/gloo-mesh-enterprise/issues/15739