Fix AppendingErrHandler issue causing errors not to be stored in passed down handlers #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen appending errors
|
Issues linked to changelog: |
inFocus7
commented
Nov 27, 2023
Co-authored-by: Marco Schmidt <[email protected]>
marcogschmidt
previously approved these changes
Nov 27, 2023
jenshu
reviewed
Nov 27, 2023
jenshu
reviewed
Nov 27, 2023
marcogschmidt
approved these changes
Nov 27, 2023
jenshu
approved these changes
Nov 27, 2023
|
github actions were unstable for a while and https://www.githubstatus.com states it's better now. going to look if I can kick them without having to push and require re-reviews |
soloio-bulldozer
bot
deleted the
fix-errors-not-being-stored-in-error-handlers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AppendErrorHandlerAppendErrorHandlerworks as expected (appending errors)Context
This was caught while debugging an issue in Portal. A failed
upsertdid not result in aState: Failedin Portal due to no errors in theAppendingErrHandler.From more debugging I noticed that the
AppendingErrHandlerdid have the expected error duringsyncListhere, but the error did not propagate upwards toSyncLocalClusterhere.This was due to reference vs value/copy modifications, where in this case the
errHandlerstored the error in a copy of the object instead of the object itself. Updating theAppendingErrHandlermethods to use*AppendingErrHandlerfixed the issue.BOT NOTES:
resolves #517