Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

feat: add warning message for loading module from CDN directly #3695

Closed
wants to merge 3 commits into from

Conversation

loatheb
Copy link

@loatheb loatheb commented Dec 9, 2024

For web3 projects to load modules, it is very dangerous to load modules from CDN directly using tags without using build tools.

Such problems have occurred in the past with ledger and solana/web3.js.As a result, once the package is tampered with, even if the project is not updated, it will be affected immediately.

Therefore, mark it clearly in the document and do not use tag to load modules directly from CDN.

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 5050002

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Dec 9, 2024
@steveluscher
Copy link
Contributor

The 2.x line has moved. Can you reopen this PR at https://github.com/anza-xyz/solana-web3.js so that you get credit for the change?

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants