This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
feat: add warning message for loading module from CDN directly #3695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For web3 projects to load modules, it is very dangerous to load modules from CDN directly using tags without using build tools.
Such problems have occurred in the past with ledger and
solana/web3.js
.As a result, once the package is tampered with, even if the project is not updated, it will be affected immediately.Therefore, mark it clearly in the document and do not use tag to load modules directly from CDN.