This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 918
Remove unused RpcSubscriptionsRequest type #3391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 17, 2024
lorisleiva
force-pushed
the
loris/remove-unused-rpcs-type
branch
4 times, most recently
from
October 18, 2024 09:20
1c68cd2
to
601d031
Compare
lorisleiva
changed the base branch from
master
to
loris/disable-node-23-tests
October 18, 2024 09:20
lorisleiva
force-pushed
the
loris/remove-unused-rpcs-type
branch
from
October 21, 2024 11:11
601d031
to
ba88104
Compare
This was referenced Oct 21, 2024
mcintyre94
approved these changes
Oct 22, 2024
steveluscher
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lorisleiva
force-pushed
the
loris/remove-unused-rpcs-type
branch
from
October 23, 2024 08:43
ba88104
to
3391bd5
Compare
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
RpcSubscriptionsRequest
which was used in the previous implementation of RPC Subscriptions but no longer is.