Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many changes #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jrsfiend
Copy link

@jrsfiend jrsfiend commented Oct 28, 2023

This has gotten some basic imports to work, in the hopes we can get tf / pytorch to work.

notably, tf now fails on trying to load os.py.

Can we add the contents of the python*.**/lib/*.py libraries to sealang?

check the changelog

- Functions have been upgraded to many levels with <3 from stacc
- Allow non-constant constants maybe, with <3 from stacc
- Allow more constants with <3 from stacc
- Body-only implementation of Try statements with <3 from stacc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much <3 from stacc. Thanks for this!

Err(Error::InvalidConstant)
} else {
} else */{
Copy link

@mikemaccana mikemaccana Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth just deleting the dead code, we can get it back from git history if we need it, and the next dev will wonder why it's commented out. This isn't a PR review (I'm new to Rust so not really qualified) just as a general ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants