-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tokens/spl-token-minter/poseidon #296
Added tokens/spl-token-minter/poseidon #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission! To verify the technical implementation, please complete these steps:
- Merge the main branch into your PR to get the latest updates
- Run
pnpm fix
at the project root for consistent code style - Ensure your implementation includes:
- Transpiled Anchor program in the
programs
folder - TypeScript files in the
ts-programs
folder
- Transpiled Anchor program in the
- Run
poseidon sync
to synchronize program ID and keys - Run
cargo fmt
andcargo clippy
for Rust code quality - Push your changes
Please note: This review is to verify technical completeness of the submission
Let me know once you've completed these steps and I'll review again. Thanks!
33a9f57
to
c4a1126
Compare
gm @heyAyushh , I've completed the requested steps:
Please review again. Thank you! |
Key Differences from previous spl-token-minter PR:
Poseidon's transpiler does not compile initializeMint function of poseidon library to rust yet, so this is done manually in lib.rs using Anchor's InitializeMint.
I have raised issue to poseidon for this: Issue in Transpilation of Poseidon to Anchor Rust – In initializeMint function Turbin3/poseidon#21
When transpiling Solana programs with Poseidon, the #[account(mut)] attribute is not automatically applied to mint_account in the generated code.
I have raised issue to poseidon for this: Missing #[account(mut)] attribute on mint_acccount in anchor code transpiled using Poseidon Transpiler Turbin3/poseidon#31
Edit- Issue resolved 🚀
After transpilation, the payer field in the associated token account setup is incorrectly assigned using camelcase.
I have raised issue to poseidon for this: Incorrect Payer Assignment in Poseidon Transpiler while initializing TokenAccount Turbin3/poseidon#32
Edit- Issue resolved 🚀
Incorrect Usage of new_with_signer instead of new in CpiContext Transpilation, even when no signer is needed.
I have raised issue to poseidon for this: Incorrect Usage of new_with_signer Instead of new in CpiContext Transpilation Turbin3/poseidon#33
Edit- Issue resolved 🚀
Followed the original exact program structure from the spl-token-minter example in Anchor.
Includes both Anchor and Bankrun tests, providing comprehensive test coverage that was missing in previous PR.
Required to include "anchor-spl" and anchor-lang = { version = "0.30.1", features = ["init-if-needed"] } dependency using cargo
and add "anchor-spl/idl-build" to idl-build list
replaced all occurrences of yarn with pnpm to maintain consistency across the project.
executed pnpm fix to ensure code quality.
committed the pnpm-lock.yaml file to the repository.