feat: preliminary use of react-native-worklets in reanimated #6807
+99
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the title
tjzel
added
the
Check compatibility
tjzel
commented
Dec 12, 2024
There was a problem hiding this comment.
Additional find_package and linking here is due to fact that react-native-reanimated/android/src/main/cpp/reanimated/CMakeLists.txt and react-native-reanimated/android/src/main/cpp/worklets/CMakeLists.txt aren't working in separation. Not including the worklets' CMakeLists.txt causes Reanimated to fail at compilation because it depends on it secretly.
piaskowyk
reviewed
Dec 18, 2024
packages/react-native-reanimated/android/src/main/cpp/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
tomekzaw
reviewed
Jan 10, 2025
tomekzaw
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding necessary code to detect if
react-native-workletsis available and change the build behavior. At the moment we forcefully make itfalsesincereact-native-workletsis a stub.Test plan
CI