chore: make actions names match their titles, cleanup

software-mansion · Aug 8, 2024 · db11705 · db11705
1 parent 005b7a2
commit db11705
Show file tree

Hide file tree

Showing 40 changed files with 252 additions and 298 deletions.
diff --git a/.github/workflows/build-v8-nightly.yml → ...ows/V8-reanimated-build-check-nightly.yml b/.github/workflows/build-v8-nightly.yml → ...ows/V8-reanimated-build-check-nightly.yml
@@ -1,4 +1,4 @@
-name: Test V8 on Android nightly
+name: V8 Reanimated build check [Nightly]
 env:
   YARN_ENABLE_IMMUTABLE_INSTALLS: 0
 on:

diff --git a/.github/workflows/validate-plugin.yml → ...b/workflows/babel-plugin-static-check.yml b/.github/workflows/validate-plugin.yml → ...b/workflows/babel-plugin-static-check.yml
@@ -1,4 +1,4 @@
-name: Validate plugin
+name: Babel plugin static check
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:
@@ -35,10 +35,7 @@ jobs:
 
       - name: Install monorepo dependencies
         run: yarn install --immutable
-      - name: Install Reanimated node dependencies
-        working-directory: packages/react-native-reanimated
-        run: yarn install
-      - name: Build package
+      - name: Build Reanimated
         working-directory: packages/react-native-reanimated
         run: yarn build
 

diff --git a/.github/workflows/build-monorepo-nightly.yml b/.github/workflows/build-monorepo-nightly.yml
diff --git a/.github/workflows/build-release-npm-package-rea3.yml b/.github/workflows/build-release-npm-package-rea3.yml
diff --git a/.github/workflows/docs-check.yml → ...workflows/docs-reanimated-build-check.yml b/.github/workflows/docs-check.yml → ...workflows/docs-reanimated-build-check.yml
@@ -1,4 +1,4 @@
-name: Test docs build
+name: Docs Reanimated build check
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:

diff --git a/...hub/workflows/publish-reanimated-docs.yml → ...hub/workflows/docs-reanimated-publish.yml b/...hub/workflows/publish-reanimated-docs.yml → ...hub/workflows/docs-reanimated-publish.yml
@@ -1,4 +1,4 @@
-name: Publish Reanimated Docs
+name: Docs Reanimated publish
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:

diff --git a/.github/workflows/android-build.yml → ...workflows/example-android-build-check.yml b/.github/workflows/android-build.yml → ...workflows/example-android-build-check.yml
@@ -1,4 +1,4 @@
-name: Test Android build
+name: Example Android build check
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:
@@ -41,36 +41,28 @@ jobs:
       - name: Check out Git repository
         uses: actions/checkout@v4
 
-      - name: Install dependencies in root
-        run: yarn install --immutable
-
       - name: Setup Java 17
         uses: actions/setup-java@v3
         with:
           distribution: 'zulu'
           java-version: 17
-
-      - name: Restore Reanimated node_modules from cache
+      # TODO: Install deps only when cache failed (use id and outputs)
+      # TODO: Check if this optimization works with new yarn
+      # TODO: Check if we should cache `yarn's` cache instead
+      - name: Restore node_modules from cache
         uses: actions/cache@v3
         with:
-          path: packages/react-native-reanimated/node_modules
-          key: ${{ runner.os }}-android-node-modules-reanimated-${{ hashFiles('packages/react-native-reanimated/yarn.lock') }}
-          restore-keys: ${{ runner.os }}-android-node-modules-reanimated-
-
-      - name: Install Reanimated node_modules
-        working-directory: packages/react-native-reanimated
-        run: yarn install --immutable
-
+          path: .
+          key: ${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}
+          restore-keys: ${{ runner.os }}-node-modules-
       - name: Restore app node_modules from cache
         uses: actions/cache@v3
         with:
           path: ${{ matrix.working-directory }}/node_modules
-          key: ${{ runner.os }}-android-node-modules-${{ matrix.working-directory }}-${{ hashFiles(format('{0}/yarn.lock', matrix.working-directory)) }}
-          restore-keys: ${{ runner.os }}-android-node-modules-${{ matrix.working-directory }}-
-
-      - name: Install app node_modules
-        working-directory: ${{ matrix.working-directory }}
-        run: yarn install
+          key: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-${{ hashFiles(format('{0}/yarn.lock', matrix.working-directory)) }}
+          restore-keys: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-
+      - name: Install monorepo node dependencies
+        run: yarn install --immutable
 
       - name: Build app
         working-directory: ${{ matrix.working-directory }}/android

diff --git a/.github/workflows/ios-build.yml → ...hub/workflows/example-ios-build-check.yml b/.github/workflows/ios-build.yml → ...hub/workflows/example-ios-build-check.yml
@@ -1,4 +1,4 @@
-name: Test iOS build
+name: Example iOS build check
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:
@@ -45,29 +45,22 @@ jobs:
       - name: Check out Git repository
         uses: actions/checkout@v4
 
-      - name: Install monorepo node dependencies
-        run: yarn install
-      - name: Restore Reanimated node_modules from cache
+      # Does this optimization even work with new yarn?
+      # Perhaps we should cache `yarn's` cache instead?
+      - name: Restore node_modules from cache
         uses: actions/cache@v3
         with:
-          path: packages/react-native-reanimated/node_modules
-          key: ${{ runner.os }}-node-modules-reanimated-${{ hashFiles('packages/react-native-reanimated/yarn.lock') }}
-          restore-keys: ${{ runner.os }}-node-modules-reanimated-
-
-      - name: Install Reanimated node dependencies
-        working-directory: packages/react-native-reanimated
-        run: yarn install
-
+          path: .
+          key: ${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}
+          restore-keys: ${{ runner.os }}-node-modules-
       - name: Restore app node_modules from cache
         uses: actions/cache@v3
         with:
           path: ${{ matrix.working-directory }}/node_modules
           key: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-${{ hashFiles(format('{0}/yarn.lock', matrix.working-directory)) }}
           restore-keys: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-
-
-      - name: Install app node_modules
-        working-directory: ${{ matrix.working-directory }}
-        run: yarn install
+      - name: Install monorepo node dependencies
+        run: yarn install --immutable
 
       - name: Restore Pods from cache
         uses: actions/cache@v3

diff --git a/.github/workflows/macos-build.yml → ...b/workflows/example-macos-build-check.yml b/.github/workflows/macos-build.yml → ...b/workflows/example-macos-build-check.yml
@@ -1,4 +1,4 @@
-name: Test macOS build
+name: Example macOS build check
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:
@@ -41,32 +41,28 @@ jobs:
       - name: Check out Git repository
         uses: actions/checkout@v4
 
-      - name: Install monorepo node dependencies
-        run: yarn install
-
-      - name: Restore Reanimated node_modules from cache
+      # Does this optimization even work with new yarn?
+      # Perhaps we should cache `yarn's` cache instead?
+      - name: Restore node_modules from cache
+        id: monorepo-cache
         uses: actions/cache@v3
         with:
-          path: packages/react-native-reanimated/node_modules
-          key: ${{ runner.os }}-macos-node-modules-reanimated-${{ hashFiles('packages/react-native-reanimated/yarn.lock') }}
-          restore-keys: ${{ runner.os }}-macos-node-modules-reanimated-
-
-      - name: Install Reanimated node_modules
-        working-directory: packages/react-native-reanimated
-        run: yarn install
-
+          path: .
+          key: ${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}
+          restore-keys: ${{ runner.os }}-node-modules-
       - name: Restore app node_modules from cache
+        id: app-cache
         uses: actions/cache@v3
         with:
-          path: ${{ env.WORKING_DIRECTORY }}/node_modules
-          key: ${{ runner.os }}-macos-node-modules-${{ env.WORKING_DIRECTORY }}-${{ hashFiles(format('{0}/yarn.lock', env.WORKING_DIRECTORY)) }}
-          restore-keys: ${{ runner.os }}-macos-node-modules-${{ env.WORKING_DIRECTORY }}-
-
-      - name: Install app node_modules
-        working-directory: ${{ env.WORKING_DIRECTORY }}
-        run: yarn install
+          path: ${{ ENV.WORKING_DIRECTORY }}/node_modules
+          key: ${{ runner.os }}-node-modules-${{ ENV.WORKING_DIRECTORY }}-${{ hashFiles(format('{0}/yarn.lock', ENV.WORKING_DIRECTORY)) }}
+          restore-keys: ${{ runner.os }}-node-modules-${{ ENV.WORKING_DIRECTORY }}-
+      - name: Install monorepo node dependencies
+        if: steps.monorepo-cache.outputs.cache-hit != 'true' || steps.app-cache.outputs.cache-hit != 'true'
+        run: yarn install --immutable
 
       - name: Restore Pods from cache
+        id: pods-cache
         uses: actions/cache@v3
         with:
           path: |
@@ -76,6 +72,7 @@ jobs:
           key: ${{ runner.os }}-macos-pods-${{ env.WORKING_DIRECTORY }}-${{ hashFiles(format('{0}/macos/Podfile.lock', env.WORKING_DIRECTORY)) }}
 
       - name: Install Pods
+        if: steps.pods-cache.outputs.cache-hit != 'true'
         working-directory: ${{ env.WORKING_DIRECTORY }}/macos
         run: bundle install && bundle exec pod install
 

diff --git a/.github/workflows/build-next-example.yml → ...ows/example-next-build-check-and-test.yml b/.github/workflows/build-next-example.yml → ...ows/example-next-build-check-and-test.yml
@@ -1,4 +1,4 @@
-name: Build/test NextExample
+name: Example Next build check and tests
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:
@@ -22,17 +22,10 @@ jobs:
         uses: actions/checkout@v4
       - name: Install monorepo node dependencies
         run: yarn install --immutable
-      - name: Install Reanimated node dependencies
-        working-directory: packages/react-native-reanimated
-        run: yarn install --immutable
       - name: Build Reanimated package
         working-directory: packages/react-native-reanimated
         run: yarn build
 
-      - name: Install NextExample node_modules
-        working-directory: apps/next-example
-        run: yarn install --immutable
-
       - name: Compile production build
         working-directory: apps/next-example
         run: yarn build:next

diff --git a/.github/workflows/tvos-build.yml → ...ub/workflows/example-tvos-build-check.yml b/.github/workflows/tvos-build.yml → ...ub/workflows/example-tvos-build-check.yml
@@ -1,4 +1,4 @@
-name: Test tvOS build
+name: Example tvOS build check
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:
@@ -40,7 +40,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Install monorepo node dependencies
-        run: yarn install
+        run: yarn install --immutable
 
       - name: Restore Reanimated node_modules from cache
         uses: actions/cache@v3
@@ -51,7 +51,7 @@ jobs:
 
       - name: Install Reanimated node_modules
         working-directory: packages/react-native-reanimated
-        run: yarn install
+        run: yarn install --immutable
 
       - name: Restore app node_modules from cache
         uses: actions/cache@v3
@@ -62,7 +62,7 @@ jobs:
 
       - name: Install app node_modules
         working-directory: ${{ env.WORKING_DIRECTORY }}
-        run: yarn install
+        run: yarn install --immutable
 
       - name: Restore Pods from cache
         uses: actions/cache@v3

diff --git a/.../workflows/static-example-apps-checks.yml → ...ows/example-typescript-check-and-lint.yml b/.../workflows/static-example-apps-checks.yml → ...ows/example-typescript-check-and-lint.yml
@@ -1,4 +1,4 @@
-name: Test TypeScript and Lint in examples
+name: Example Typescript check and lint
 env:
   YARN_ENABLE_HARDENED_MODE: 0
 on:
@@ -16,12 +16,15 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        working-directory:
-          [
-            apps/paper-example,
+        working-directory: [
+            apps/common-app,
             apps/fabric-example,
-            apps/web-example,
+            apps/macos-example,
+            # We don't check for Next.
+            # apps/next-example,
+            apps/paper-example,
             apps/tvos-example,
+            apps/web-example,
           ]
     concurrency:
       group: typescript-${{ matrix.working-directory }}-${{ github.ref }}
@@ -37,16 +40,10 @@ jobs:
         run: .github/workflows/helper/clear-annotations.sh
 
       - name: Install monorepo node dependencies
-        run: yarn install
-      - name: Install Reanimated node dependencies
-        working-directory: packages/react-native-reanimated
-        run: yarn install
+        run: yarn install --immutable
       - name: Build Reanimated package
         working-directory: packages/react-native-reanimated
         run: yarn build
-      - name: Install ${{ matrix.working-directory }} app node dependencies
-        working-directory: ${{ matrix.working-directory }}
-        run: yarn
 
       - name: Check types
         working-directory: ${{ matrix.working-directory }}

diff --git a/...rkflows/check-expo-dev-client-nightly.yml → ...ws/expo-devclient-build-check-nightly.yml b/...rkflows/check-expo-dev-client-nightly.yml → ...ws/expo-devclient-build-check-nightly.yml
@@ -1,4 +1,4 @@
-name: Check Expo dev-client nightly build
+name: Expo DevClient build check [Nightly]
 env:
   YARN_ENABLE_HARDENED_MODE: 0
   SCRIPT_PATH: ${{github.workspace}}/reanimated_repo/.github/workflows/helper/configureDevClient.js

diff --git a/.github/workflows/close-when-stale.yml → ...flows/github-close-when-stale-nightly.yml b/.github/workflows/close-when-stale.yml → ...flows/github-close-when-stale-nightly.yml
@@ -1,7 +1,7 @@
-name: Check for stale issues
+name: Github "Close when stale" [Nightly]
 on:
   schedule:
-    - cron: "37 21 * * *" # at 21:37 every day
+    - cron: '37 21 * * *' # at 21:37 every day
   issues:
     types: [edited]
   issue_comment:
@@ -16,12 +16,12 @@ jobs:
       - name: Checkout Actions
         uses: actions/checkout@v4
         with:
-          repository: "software-mansion-labs/swmansion-bot"
+          repository: 'software-mansion-labs/swmansion-bot'
           ref: stable
 
       - uses: actions/cache@v3
         with:
-          path: "**/node_modules"
+          path: '**/node_modules'
           key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
 
       - name: Install Actions
@@ -30,5 +30,5 @@ jobs:
       - name: Close when stale
         uses: ./close-when-stale
         with:
-          close-when-stale-label: "Close when stale"
+          close-when-stale-label: 'Close when stale'
           days-to-close: 14
diff --git a/.github/workflows/platforms.yml → ...orkflows/github-issue-platforms-check.yml b/.github/workflows/platforms.yml → ...orkflows/github-issue-platforms-check.yml
@@ -1,4 +1,4 @@
-name: Check for platforms
+name: Github issue platforms check
 on:
   issues:
     types: [opened, edited]
@@ -14,12 +14,12 @@ jobs:
       - name: Checkout Actions
         uses: actions/checkout@v4
         with:
-          repository: "software-mansion-labs/swmansion-bot"
+          repository: 'software-mansion-labs/swmansion-bot'
           ref: stable
 
       - uses: actions/cache@v3
         with:
-          path: "**/node_modules"
+          path: '**/node_modules'
           key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
 
       - name: Install Actions