Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/jsi and jni #235

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Refactor/jsi and jni #235

merged 11 commits into from
Dec 13, 2024

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Dec 11, 2024

Closes #230

Introduced changes

  • Removed wrappers
  • Refactored AudioAPIInstaller installation
  • Implemented JsiHostObject - base class for all our Host Objects
  • Refactored all Host Objects to use JsiHostObject, what leads to removing lot of repeating code

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@maciejmakowski2003 maciejmakowski2003 self-assigned this Dec 11, 2024
@maciejmakowski2003 maciejmakowski2003 marked this pull request as ready for review December 13, 2024 11:37
Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Work! 🔥
image

@maciejmakowski2003 maciejmakowski2003 merged commit 5cf240b into main Dec 13, 2024
11 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the refactor/jsi-and-jni branch December 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor jni and jsi interop
2 participants